Subcomponents handling #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and flip the order for constrain
Co-authored-by: Ian Neal <ian@veridise.com>
Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
I looked through those 4 tests and the output generated from this branch. Subcomponents were the last thing that needed support so success is expected now. Add the checks generated from the python script. |
tim-hoffman
reviewed
Jan 7, 2026
tim-hoffman
reviewed
Jan 7, 2026
iangneal
reviewed
Jan 7, 2026
| .unwrap_or_else(|| panic!("Input {:?} not found for type {:?}", input, name)); | ||
| match wire.get_type() { | ||
| WireType::Signal => FeltType::new(self.context).into(), | ||
| WireType::Bus(name) => StructType::from_str(self.context, &name).into(), |
There was a problem hiding this comment.
How are array inputs handled? Can you add a passing test with an array input, or is this TODO still?
Collaborator
Author
There was a problem hiding this comment.
Still a TODO I think
Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some support for subcomponents.
Fixes #177
Tasks