Skip to content

⚡️ Speed up method bittrade.parse_ticker by 20% #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method bittrade.parse_ticker by 20% #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 26 additions & 18 deletions python/ccxt/async_support/bittrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,36 +643,44 @@ def parse_ticker(self, ticker: dict, market: Market = None) -> Ticker:
# "askSize": 0.4156
# }
#
symbol = self.safe_symbol(None, market)
timestamp = self.safe_integer(ticker, 'ts')
# OPTIMIZATION: cache methods and avoid attribute lookup when hot
safe_symbol = self.safe_symbol
safe_integer = self.safe_integer
safe_string = self.safe_string

symbol = safe_symbol(None, market)
timestamp = safe_integer(ticker, 'ts')
bid = None
bidVolume = None
ask = None
askVolume = None
if 'bid' in ticker:
if isinstance(ticker['bid'], list):
bid = self.safe_string(ticker['bid'], 0)
bidVolume = self.safe_string(ticker['bid'], 1)
bid_val = ticker['bid']
if isinstance(bid_val, list):
bid = safe_string(bid_val, 0)
bidVolume = safe_string(bid_val, 1)
else:
bid = self.safe_string(ticker, 'bid')
bidVolume = self.safe_string(ticker, 'bidSize')
bid = safe_string(ticker, 'bid')
bidVolume = safe_string(ticker, 'bidSize')
if 'ask' in ticker:
if isinstance(ticker['ask'], list):
ask = self.safe_string(ticker['ask'], 0)
askVolume = self.safe_string(ticker['ask'], 1)
ask_val = ticker['ask']
if isinstance(ask_val, list):
ask = safe_string(ask_val, 0)
askVolume = safe_string(ask_val, 1)
else:
ask = self.safe_string(ticker, 'ask')
askVolume = self.safe_string(ticker, 'askSize')
open = self.safe_string(ticker, 'open')
close = self.safe_string(ticker, 'close')
baseVolume = self.safe_string(ticker, 'amount')
quoteVolume = self.safe_string(ticker, 'vol')
ask = safe_string(ticker, 'ask')
askVolume = safe_string(ticker, 'askSize')
open = safe_string(ticker, 'open')
close = safe_string(ticker, 'close')
baseVolume = safe_string(ticker, 'amount')
quoteVolume = safe_string(ticker, 'vol')
# Batch construction to avoid global lookups
return self.safe_ticker({
'symbol': symbol,
'timestamp': timestamp,
'datetime': self.iso8601(timestamp),
'high': self.safe_string(ticker, 'high'),
'low': self.safe_string(ticker, 'low'),
'high': safe_string(ticker, 'high'),
'low': safe_string(ticker, 'low'),
'bid': bid,
'bidVolume': bidVolume,
'ask': ask,
Expand Down
Loading