-
Notifications
You must be signed in to change notification settings - Fork 10.5k
kalman VOACC #36965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kalman VOACC #36965
Conversation
|
Here the model predicted the lead to be going above 25 m/s when it first detected it, which was way off, causing no braking whatsoever: https://connect.comma.ai/0f79c454f812791a/000000a3--e1e54de187/1037/1067 Using a kf to predict lead velocity from distance + compensating with aEgo, it instantly snaps to ~15 m/s which is what I roughly calculated with derivative on the model lead distance. Plus my speed at the lowest point was 17 m/s and I was still faster than the lead, so the kf's prediction of 15 m/s instantly upon detecting the lead looks much better!
Left is simple derivative of distance over time, right is kf with xStd and aEgo compensation (so kf doesn't have to deal with dRel changes from ego)
|
Is this why coming to a lead car on the highway takes a while to converge to the lead car speed? (Usually gets close and brakes hard, oscillating behind it a few times to match lead car speed) |
|
yes. @haraschax is working on a new model to fix this |




WIP. dumb kf on x is not good, because we don't use xStd? or use ego at all?
(only dRel is relevant)

Using xStd works pretty well!
(only dRel is relevant)
