A general update #46
Open
A general update #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0g
commented
Mar 24, 2017
m0g
commented
- Updated NAN
- Bundled exiv2 in the source
- Windows support
- OSX support
|
This seems to fix #45 too! Would be great to have it merged. |
Owner
|
Awesome work @m0g, thank you! Build is failing for node 0.8, let me update the travis file and remove non LTS versions, get this passing and will merge then :-) |
|
This does seem like a good update, but would including a certain version of exiv2 in the source make it harder to update later on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.