Support for menus with sections and optional image. #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…column wide dropdown. Support for an optional image in the dropdown.
Contributor
|
Looks good! |
GeorgeWL
approved these changes
Sep 14, 2017
Contributor
GeorgeWL
left a comment
GeorgeWL
left a comment
There was a problem hiding this comment.
ooks pretty good.
Does this help fix the dropdown issue too btw?
Contributor
Author
|
@GeorgeWL which dropdown issue are you talking about? |
Contributor
|
Any progress on getting this merged? |
Contributor
Author
|
@ryanfox1985 @adrianmo when could this be merged? |
Contributor
Author
|
@ryanfox1985 @adrianmo ping. |
|
Is there any chance of getting this merged @ryanfox1985 @adrianmo looks like its been sitting for a while and it would be awesome to have this functionality! |
Contributor
|
@ringods fix the merge conflicts and we can merge |
Contributor
|
closed in favour #307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GeorgeWL @adrianmo,
I reviewed the menu navigation to support more of the upstream theme. This PR offers:
Theme adapted and documentation added.
Part of #101