Support for menus with sections and optional image

[ctindel]

This is a port of the 2-year old PR #111 so it can be merged cleanly originally written by @ringods

This PR offers:

• dropdown menu with single list of menu items
• dropdown menu with 4 columns of menu items, grouped in sections
• dropdown menu with 2 column wide image, followed by 2 columns of menu items grouped in sections.

Part of #101

[ctindel]

@GeorgeWL @ryanfox1985 Hi, just wanted to see if we could get this merged at some point, I know it was mentioned recently on the 2 year old PR that you'd accept it if the merge conflicts were removed.

[ctindel]

@ryanfox1985 @GeorgeWL any chance of getting this merged? Wasn't sure if it was blocked behind something else. Thanks!

[GeorgeWL]

looks fine @devcows

[ryanfox1985]

I will test it during the week.

[ringods]

Use to the unique ...

I see a typo now in my own 2-year old work. 😜

[GeorgeWL]

ha, removing just one word isn't the worst thing 😛

[salim-b]

This PR has some serious deficiencies which should be solved before merging:

• It breaks navigation highlighting, originally added in Active class on top level items and blog post parent menu item #191 and refactored to rely on identifier keys in improve navigation highlighting: #211. I currently don't have the time to look into it, but I see you completely removed the highlighting code in layouts/partials/nav.html and also changed the identifier keys from some_id to menu.some_id...

• The menu in the example site is very confusing since most of the linked subpages don't actually exist. I really dont' see any benefit in mimicking the upstream theme halfway through.

[ctindel]

@salim-b I may be out of my element here since I was just forward-porting someone else's code and it worked ok on my site. I'm not sure what you mean by navigation highlighting. I'm running this code on my site as i roll over the top level menu items as well as the sub menu items they do highlight. Is there another type of highlighting is broken?

That said I didn't realize there was a version of universal theme that had this already unreleased so if you don't think it's worth taking the change maybe we can just drop it.

[salim-b]

I'm running this code on my site as i roll over the top level menu items as well as the sub menu items they do highlight. Is there another type of highlighting is broken?

Yes, the respective top level item should stay highlighted when the corresponding page is visited 😉

I didn't realize there was a version of universal theme that had this already unreleased

I don't really understand what you mean by "already unreleased", but there is ongoing effort to port this whole hugo theme to the new Universal v2 upstream theme in #246

so if you don't think it's worth taking the change maybe we can just drop it.

Personally I don't need the extended menus, so I probably won't put much work into improving this PR. But since there's no ETA for #246, it might make sense for others to do that work...

[ryanfox1985]

shall I close #101 in favour of this PR?

[ryanfox1985]

I'm running this code on my site as i roll over the top level menu items as well as the sub menu items they do highlight. Is there another type of highlighting is broken?

it's not working well the highlighting menu.

[ryanfox1985]

I updated #111 into #307

[ryanfox1985]

closed in favour of #307