Implement pca patch/plane detec #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before its replacement
DamienGilliard
changed the base branch from
release/2.0.0
to
feature/pose_comparison
eleniv3d
reviewed
Jan 7, 2026
| rh_bb_centroid = Rhino.Geometry.Point3d(df_bb_centroid[0], df_bb_centroid[1], df_bb_centroid[2]) | ||
|
|
||
| new_xDirection, new_yDirection = df_poses.select_vectors(vectors, i_assembly.beams[i].plane.XAxis, i_assembly.beams[i].plane.YAxis) | ||
| new_xDirection, new_yDirection = df_poses.select_vectors(rh_face_normals, i_assembly.beams[i].plane.XAxis, i_assembly.beams[i].plane.YAxis) |
Collaborator
There was a problem hiding this comment.
similar to comment on the other pr it seems select_vectors can return non orthonormal and even in this case 0,0,0 vectors which makes a Null Plane but still recognised as planes in ghpython. so angles etc are calculated downstream even if the plane is invalid
Collaborator
Author
There was a problem hiding this comment.
Yep, got it. The df_face_cloud.fit_plane_ransac() method returns a null vector when it is fed an invalid point cloud, hence the subsequent unintended behaviour.
eleniv3d
reviewed
Jan 7, 2026
eleniv3d
reviewed
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR concerns the implementation of a RANSAC plane detection on each face, to improve the pose estimation
...
And it works !!! The video hereunder shows successive computations of the poses of 3 point clouds. With the previous method we had some big jumps in pose, and now it is much more stable.
Enregistrement.de.l.ecran.2025-11-24.173042.mp4
Changes include:
ToDo