Fix: Handling Symbols in Field Paths for Time Series Data #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While working with financial time series data, I encountered an issue where certain symbols (e.g.,
"SILG.L") caused values to benullwhen aligning data, so to give back to the open source community will try to fix this.This occurs because the system incorrectly treats such keys as field paths, leading to lookup failures.
Cause
The issue happens when using
event.get("not.fieldpath"). If a key path like string or does not exist as a valid field path, it returnsnull.Example:
Solution
Added a check to verify if the key exists before treating it as a field path.
If the key exists directly in the object, it is returned correctly instead of being misinterpreted.
Verification
Implemented a test case to reproduce the issue.
The test ensures that keys like "SILG.L" are handled properly.
All tests pass successfully after applying the fix.