Skip to content

Fix: Handling Symbols in Field Paths for Time Series Data #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masiafrest wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Handling Symbols in Field Paths for Time Series Data #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca0c617
add support for dot notation key
masiafrest Mar 12, 2025
1454a73
add build files
masiafrest Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/pond/lib/event.js
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 4 additions & 5 deletions packages/pond/lib/rate.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 21 additions & 17 deletions packages/pond/lib/timerange.js
View file
Open in desktop

Large diffs are not rendered by default.

110 changes: 46 additions & 64 deletions packages/pond/lib/timeseries.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions packages/pond/src/event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,9 @@ export class Event<T extends Key = Time> extends Base {
* Note: the default `field` is "value".
*/
public get(field: string | string[] = "value"): any {
if (_.isString(field) && this.data.has(field)) {
return this.getData().get(field);
}
const f = util.fieldAsArray(field);
return this.getData().getIn(f);
}
Expand Down
10 changes: 10 additions & 0 deletions packages/pond/tests/event.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ describe("Time Events", () => {
const eventValue = event1.get(["NorthRoute", "in"]);
expect(eventValue).toBe(123);
});

it("can check get values when field has a dot notation", () => {
const timestamp = time(new Date("2015-04-22T03:30:00Z"));
const event1 = event(
timestamp,
Immutable.fromJS({ "not.fieldpath": { in: 789, out: 223 } })
);
const eventValue = event1.get("not.fieldpath");
expect(eventValue.toJS()).toEqual({ in: 789, out: 223 });
});
});

describe("Indexed Events", () => {
Expand Down