Improve the sensitivity of the array_zero_value tests
#4550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where
valid = true, we want to test with aconstdeclaration, to ensure that the constructor is supported in const exprs. But in cases wherevalid = false, some of the subject types are not constructible, and may be rejected in a const declaration for that reason, even if the implementation is not properly restricting the use of zero-value constructors.This changes the test to use
constwhenvalid = trueandletwhenvalid = false, which make the the tests more sensitive to the functionality they are intending to cover.Tests still pass in Chrome. The
valid_arraycase is failing in Safari either with or without this change. With this change, theinvalid_rta,invalid_override_array, andinvalid_atomiccases fail in Firefox, which I believe accurately reflects defects in the implementation.Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.