[otbn,rtl] Clean up naming of predecoded signals #28984
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etterli
requested review from
marnovandermaas
and removed request for
a team
This unifies the naming scheme of all predecoded signals and aligns the names with the non predecoded signals. Previously, the naming was either `<component>_predec_bignum` or `<component>_bignum_predec`. Now it is `<component>_bignum_predec` which matches with <component>_bignum_operation signal naming. Signed-off-by: Pascal Etterli <pascal.etterli@lowrisc.org>
etterli
force-pushed
the
otbn-predecode-cleanup
branch
from
4c5cc48 to
17e0478
Compare
etterli
requested review from
vogelpi
and removed request for
marnovandermaas
rswarbrick
approved these changes
Jan 5, 2026
Contributor
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Looks sensible to me, and I'm a fan of the consistency.
Contributor
|
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn_alu_bignum.sv No risk to the design: this is just a naming tidy-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the naming scheme of all predecoded signals and aligns the names with the non predecoded signals.
Previously, the naming was inconsistent and either
<component>_predec_bignumor<component>_bignum_predec. Now it is<component>_bignum_predecwhich matches with<component>_bignum_operationsignal naming as well as other signals like<component>_predec_error.This relates to #4166