Backport 26558 ([rom_ext] Refactor signature verificaion functions ) #28992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Consolidate public key data into `owner_keydata_t`. 2. Eliminate RSA as a supported algorithm. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit f785f1b)
pamaury
requested review from
AlexJones0,
alees24,
cfrantz,
moidx and
timothytrippel
and removed request for
a team and
alees24
Refactor the ROM_EXT signature verification functions into a verify function that can be used both for validating application payloads and ownership operations. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit 28a96b5)
This target is a left-over from pre-ownership RSA verification and is no longer needed. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit 81f7aac)
pamaury
force-pushed
the
backport_26558
branch
from
e9f209c to
112e064
Compare
jwnrt
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26558
WARNING: #26558 contains some changes to
sival_owner.cwhich are incompatible with master because part of 26558 was not backported (eargrey 1.0.0 specific). Maybe we should look into dropping the sival config from master? I ended up hacking my way throw thesival_owner.cfile to make it compile (even if it's not used). @cfrantz @timothytrippel