Support more useful properties #304
Conversation
akashlevy
left a comment
akashlevy
left a comment
There was a problem hiding this comment.
@jjcherry56 ready for review again
| else if (property == "startpoint_clock"){ | ||
| const Clock *clk = end->path()->clock(sta_); | ||
| if (clk) | ||
| return PropertyValue(clk->name()); |
There was a problem hiding this comment.
why change it to the clock name? you can't get properties of a clock name like a clock object
There was a problem hiding this comment.
The standard behavior of most EDA tools seems to be to return strings not objects when you request properties.
There was a problem hiding this comment.
I think ideally we ensure that we are always returning strings when getting properties to be consistent with other tool behavior
| else if (property == "endpoint_clock") { | ||
| const Clock *clk = end->targetClk(sta_); | ||
| if (clk) | ||
| return PropertyValue(clk->name()); |
There was a problem hiding this comment.
See my comment above.
| else if (property == "endpoint_clock_pin") | ||
| return PropertyValue(end->targetClkPath()->pin(sta_)); | ||
| else if (property == "path_group") | ||
| return PropertyValue(sta_->search()->pathGroup(end)->name()); |
There was a problem hiding this comment.
it is plural now: pathGroups
There was a problem hiding this comment.
Hmm, I'm not seeing the API for this. Can you double check?
|
@jjcherry56 fixed two of your comments and asked for clarification on the others |
4 participants
Adding several useful properties onto STA objects for querying/filtering.