Skip to content

Conversation

@GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented May 14, 2025

What problem does this PR solve?

Issue Number: close #61100
ref pingcap/log#43

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. component/dumpling This is related to Dumpling of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2025
@tiprow
Copy link

tiprow bot commented May 14, 2025

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented May 14, 2025

/retest

@tiprow
Copy link

tiprow bot commented May 14, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 14, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-14 03:15:59.031110551 +0000 UTC m=+501425.179071768: ☑️ agreed by tangenta.
  • 2025-05-14 03:30:36.774023682 +0000 UTC m=+502302.921984897: ☑️ agreed by hawkingrei.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, Benjamin2037, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 14, 2025
@ti-chi-bot ti-chi-bot bot merged commit df4600c into pingcap:master May 14, 2025
18 checks passed
@GMHDBJD GMHDBJD added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label May 14, 2025
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented May 14, 2025

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #61102.
But this PR has conflicts, please resolve them!

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5521%. Comparing base (41045f1) to head (bf79040).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61101        +/-   ##
================================================
+ Coverage   73.1476%   73.5521%   +0.4044%     
================================================
  Files          1724       1724                
  Lines        477139     477177        +38     
================================================
+ Hits         349016     350974      +1958     
+ Misses       106718     104806      -1912     
+ Partials      21405      21397         -8     
Flag Coverage Δ
integration 42.5630% <ø> (?)
unit 72.3702% <ø> (-0.0079%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 47.5779% <ø> (+0.0137%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request May 14, 2025
ti-chi-bot bot pushed a commit that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved component/dumpling This is related to Dumpling of TiDB. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dumpling -L save logs in a directory without permission, error should be show in stderr

6 participants