-
Notifications
You must be signed in to change notification settings - Fork 6.1k
dumpling: precheck log file permisssion (#61101) #61102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dumpling: precheck log file permisssion (#61101) #61102
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@GMHDBJD This PR has conflicts, I have hold it. |
GMHDBJD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #61102 +/- ##
================================================
Coverage ? 76.4611%
================================================
Files ? 1642
Lines ? 450124
Branches ? 0
================================================
Hits ? 344170
Misses ? 85066
Partials ? 20888
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
Benjamin2037
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/merge |
|
@GMHDBJD: We have migrated to builtin 👉 Please use
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #61101
What problem does this PR solve?
Issue Number: close #61100
ref pingcap/log#43
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.