GetUserNameExW returns 0 on error, non-zero on success #1642
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmschonfeld
reviewed
Dec 16, 2025
|
|
||
| return withUnsafeTemporaryAllocation(of: WCHAR.self, capacity: Int(ulLength)) { wszBuffer in | ||
| guard GetUserNameExW(NameDisplay, wszBuffer.baseAddress!, &ulLength) == 0 else { | ||
| guard GetUserNameExW(NameDisplay, wszBuffer.baseAddress!, &ulLength) != 0 else { |
Contributor
There was a problem hiding this comment.
It looks like we have a unit test that validates that the user name is not empty but it only runs on macOS. Should we also run it on Windows to validate this behavior?
AZero13
force-pushed
the
guard-wrong
branch
2 times, most recently
from
9b99a45 to
274e0ca
Compare
I know Microsoft is not consistent on this, but yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know Microsoft is not consistent on this, but GetUserNameExW returns 0 on error.