Skip to content

GetUserNameExW returns 0 on error, non-zero on success #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GetUserNameExW returns 0 on error, non-zero on success #1642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/FoundationEssentials/ProcessInfo/ProcessInfo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ final class _ProcessInfo: Sendable {
_ = GetUserNameExW(NameDisplay, nil, &ulLength)

return withUnsafeTemporaryAllocation(of: WCHAR.self, capacity: Int(ulLength)) { wszBuffer in
guard GetUserNameExW(NameDisplay, wszBuffer.baseAddress!, &ulLength) == 0 else {
guard GetUserNameExW(NameDisplay, wszBuffer.baseAddress!, &ulLength) != 0 else {
Copy link
Contributor

@jmschonfeld jmschonfeld Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have a unit test that validates that the user name is not empty but it only runs on macOS. Should we also run it on Windows to validate this behavior?

Copy link
Contributor Author

@AZero13 AZero13 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

return ""
}
return String(decoding: wszBuffer.prefix(Int(ulLength)), as: UTF16.self)
Expand Down
2 changes: 1 addition & 1 deletion Tests/FoundationEssentialsTests/ProcessInfoTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ private struct ProcessInfoTests {
"ProcessInfo thinks we are on System 70")
}

#if os(macOS)
#if canImport(Darwin) || os(Windows)
@Test func userName() {
#expect(!ProcessInfo.processInfo.userName.isEmpty)
}
Expand Down