chore: cleanup build pipeline #1326
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a new GitHub Actions workflow to automate the plugin build and deployment process. It consolidates common build steps into an external workflow file, updates the main workflow to use two distinct jobs (staging and production), simplifies the release workflow trigger, and updates the release configuration. These changes streamline and centralize the build and release pipelines. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/main.yml (1)
327-328: Enforce Newline at File End
Static analysis indicates a missing newline at the end of the file. Adding an end-of-file newline will help maintain consistency with YAML style guidelines.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 328-328: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/build-plugin.yml (1)
146-148: Remove Trailing Spaces
Static analysis detected trailing spaces on line 147. Removing these will ensure the YAML file adheres to linting standards and avoids potential parsing issues.-<line 147 with trailing spaces>␣␣ +<line 147 without trailing spaces>🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 147-147: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/build-plugin.yml(1 hunks).github/workflows/main.yml(1 hunks).github/workflows/release-production.yml(1 hunks)release-please-config.json(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/main.yml
[error] 328-328: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/build-plugin.yml
[error] 147-147: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (5)
release-please-config.json (1)
15-16: Update Release Draft Setting
Changing"draft": falsenow means releases will be published immediately instead of being created as drafts. Ensure this aligns with your intended release process and that any downstream automation is updated accordingly..github/workflows/release-production.yml (1)
1-3: Switch to Manual Release Trigger
The workflow name has been simplified to "Publish Release" and the automaticreleasetrigger has been removed, enforcing a manual invocation viaworkflow_dispatch. This change streamlines release control—please verify that the team intends for releases to be manually triggered only..github/workflows/main.yml (2)
287-307: Integrate External Plugin Build Workflow for Staging
The addition of thebuild-plugin-staging-prjob that uses the external workflow (build-plugin.yml) helps standardize the build and deployment process for plugins. The TAG input is derived from the pull request number (defaulting to"staging"when absent), which is a neat approach.
308-328: Separate Production Build Configuration—Review TAG Parameter
Thebuild-plugin-productionjob is conditionally executed based on the release creation status, which is effective for automating production builds. Note that theTAGinput is left empty; please confirm that this is intentional. If a production release should always carry a tag, you might want to set an appropriate default or validation.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 328-328: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/build-plugin.yml (1)
1-33: New Build Plugin Workflow: Clear and Consolidated
The new reusable workflow for building and deploying the plugin component is well structured. The inputs, secrets, and job configuration make it easy to integrate this workflow into multiple jobs (staging and production).
🤖 I have created a release *beep* *boop* --- ## [4.6.4](v4.6.3...v4.6.4) (2025-04-03) ### Bug Fixes * cleanup build pipeline ([#1326](#1326)) ([60f16bd](60f16bd)) * remove unneeded workflow secret pass ([4bb00dd](4bb00dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit
New Features
Chores