(1.21.1) Fix crash when placing vertical slab into water #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… water We weren't unsetting waterlogged on the state we were using to index into the baked model map, so it didn't match and ended up dereferencing a null pointer. From what I can see this fixes both the initial crash and the inability to load back into the world afterwards.
CJMinecraft01
requested changes
Jan 3, 2026
Owner
CJMinecraft01
left a comment
CJMinecraft01
left a comment
There was a problem hiding this comment.
Thanks for spotting this simple fix! 🚀 Just a small comment on using trySetValue over setValue.
| @Override | ||
| public BakedModel getVerticalSlabModel(BlockState state, Direction side) { | ||
| return verticalModels.get(state).get(side); | ||
| final var normalisedState = state.setValue(BlockStateProperties.WATERLOGGED, false); |
Owner
There was a problem hiding this comment.
I think it's safer to use trySetValue here in case the state doesn't have the WATERLOGGED property.
Suggested change
| final var normalisedState = state.setValue(BlockStateProperties.WATERLOGGED, false); | |
| final var normalisedState = state.trySetValue(BlockStateProperties.WATERLOGGED, false); |
This was referenced Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311 - Vertical slabs crash the game when placed in water (and prevent reloading world)
It was trying to use the block state to index into a map of maps, but wasn't unsetting
waterloggedon the indexing block state first, so it ended up dereferencing a null pointer.From what I can see this fixes both the initial crash and the inability to load back into the world afterwards on all three loaders.
Presumably the same fix will have to be added for the other game versions too.