Update test environment to fix running tests on GitHub Actions #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
commented
Apr 18, 2025
clue
commented
Apr 18, 2025
WyriHaximus
approved these changes
Apr 18, 2025
mbonneau
approved these changes
Apr 25, 2025
samizdam
approved these changes
May 1, 2025
Member
Author
|
Time to move forward and get the next PRs in! |
🎉
This was referenced May 14, 2025
This was referenced May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changset updates the test environment to fix running tests on GitHub Actions. This is part 1 of reviving Ratchet as discussed in #1054, finally unblocking future progress.
With these changes applied, the existing test suite will work again as is both locally and on GitHub Actions (CI). Once merged, I'll use this as a starting point to add add newer PHP 8+ version support as discussed in #1003 and elsewhere.
Overall, this still requires a massive effort. If you want to support this project, please consider sponsoring @reactphp ❤️
Builds on top of #856, reactphp/reactphp#442, reactphp/socket#299, clue/framework-x#267 and others